Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

@coderabbitai you can now review the entire change. (Skip .json files)

#!/bin/bash
# Get the list of changed files (non-JSON) in PR `#9082`
gh pr view 9082 --repo makeplane/plane --json files --jq '.files[].path' | grep -v '\.json$'

#!/bin/bash
# Get the full diff for non-JSON files in PR `#9082`
gh pr diff 9082 --repo makeplane/plane | grep -v '^diff --git.*\.json' | python3 - <<'PYEOF'
import sys

content = sys.stdin.read()

# Split by diff headers
import re
chunks = re.split(r'(?=^diff --git )', content, flags=re.MULTILINE)

# Filter out JSON file diffs
non_json_chunks = [c for c in chunks if not re.match(r'diff --git a/.*\.json', c)]

print(''.join(non_json_chunks))
PYEOF

#!/bin/bash
# Get the diff differently
gh api repos/makeplane/plane/pulls/9082/files --paginate --jq '.[] | select(.filename | endswith(".json") | not) | "=== FILE: \(.filename) ===\n\(.patch // "no patch")"' 2>/dev/null | head -5000

@xuhongbo — here is the full review of the non-JSON changes in this PR. Overall the approach is solid and the i18n coverage is thorough; a few items below are worth addressing.

🔍 Code Review

🐛 Issues / Potential Regressions

1. autoFocus removed from the link edit dialog's URL input (packages/editor/src/core/components/links/link-edit-view.tsx)

The autoFocus prop was dropped from InputView entirely. Unlike page-load auto-focus (which has SSR/testing concerns), this dialog is opened by user action, so auto-focusing the URL field is the correct UX. Without it, users must manually click/tab before typing.

-function InputView({ label, value, placeholder, onChange, autoFocus }: InputViewProps) {
+function InputView({ label, value, placeholder, onChange }: InputViewProps) {
   ...
-      autoFocus={autoFocus}

Suggestion: Keep autoFocus on the URL field, or use a useEffect(() => { ref.current?.focus(); }, []) pattern like the email form does in this same PR, so the first input receives focus when the dialog opens.

2. autoFocus removed from filter search inputs

Both apps/web/core/components/inbox/inbox-filter/filters/filter-selection.tsx and apps/space/components/issues/filters/selection.tsx had autoFocus (or autoFocus={!isMobile}) removed from their search inputs. For a dropdown that opens on user action, this means desktop users need an extra click before they can type. The email form in this PR uses useEffect instead — consider applying the same pattern here.

3. Duplicate PAST_DURATION_FILTER_I18N_KEYS map

The exact same constant is defined in two files:

• apps/web/core/components/inbox/inbox-filter/filters/date.tsx
• apps/web/core/components/inbox/inbox-filter/applied-filters/date.tsx

Consider extracting it to a shared location (e.g. a constants.ts in the inbox filter directory) to keep it DRY.

4. Hardcoded English defaults in Spinner and Banner components

// packages/propel/src/spinners/circular-spinner.tsx
export function Spinner({ label = "Loading..." }: ISpinner)

// packages/propel/src/banner/banner.tsx
dismissLabel = "Dismiss banner",

These propel-level components are locale-agnostic — the defaults will always render English regardless of the active locale. Since callers already hold a t() instance, it is better to make these props required (or document that callers must always pass the translated string) rather than silently falling back to English.

5. Fragile sentence-splitting for Terms & Conditions (apps/space/components/account/terms-and-conditions.tsx)

{isSignUp ? t("space_public.by_creating_account") : t("space_public.by_signing_in")},{" "}
{t("space_public.you_agree_to_our")}

Splitting a single grammatical sentence across three separate keys is fragile for languages that have different word order or punctuation rules. A better pattern is to use a single key with an interpolated variable and render the link separately, or use Trans from react-i18next which handles inline elements within translated strings.

✅ Noteworthy Improvements Bundled In

These are positive changes worth acknowledging:

• div → button conversions throughout inbox filters applied-filters, sidebar tab navigation, onboarding invitations — good accessibility fixes.
• Logic fix in join-invites.tsx: invitationsRespond.length <= 0 && !invitation?.role changed to || !selectedInvitation?.role. The original && would allow submission with no invitations selected as long as a role existed; || is correct.
• tabIndex={1} → tabIndex={0} in peek-overview/header.tsx — tabIndex=1 breaks natural tab order; 0 is correct.
• isButtonDisabled logic simplifications in password.tsx, usecase/root.tsx, profile/root.tsx — removes the confusing double-negation pattern.
• Complete useMemo/useCallback dependency arrays (e.g. issue-root.tsx adding archiveIssue, projectId, removeIssue, t, workspaceSlug).
• role="dialog" + aria-label added to link edit view container.
• return added before router.push in async .then() callbacks — avoids unhandled floating promises.
• onClick removed from <img> in profile/root.tsx — images with click handlers are an accessibility anti-pattern; the labeled button below it is the correct interaction target.
• Shadow-variable renames (label → labelInfo, member → memberInfo, email → emailId, pageId → targetPageId) — improves readability.

💬 Minor Notes

• t("space_auth.confirm_password") is used for both the <label> and the placeholder in password.tsx. A dedicated placeholder key (e.g. space_auth.confirm_password_placeholder) would be more descriptive.
• The error_description_prefix / error_description_middle key names in apps/space/app/error.tsx are not very descriptive — something like error_description_before_email / error_description_before_forum would communicate intent more clearly.
• return undefined in .then() handlers (e.g. peek-overview/header.tsx, issue-properties.tsx) satisfies TypeScript's void return type but looks unusual — a comment or type cast would make the intent clearer to future readers.

@coderabbitai review the latest changes. Skip .json files.

#!/bin/bash
# Get all changed non-JSON files in PR `#9082` with their patches
gh api repos/makeplane/plane/pulls/9082/files --paginate \
  --jq '.[] | select(.filename | endswith(".json") | not) | "=== FILE: \(.filename) ===\nSTATUS: \(.status)\n\(.patch // "no patch")\n"' 2>/dev/null

@xuhongbo — here is the review of the latest non-JSON changes.

🔍 Code Review

✅ Previous Issues Addressed

All the major items flagged in the last review have been resolved:

• autoFocus → useEffect + ref in link-edit-view.tsx, filter-selection.tsx (both apps/web and apps/space), and email.tsx.
• tabIndex={1} → tabIndex={0} in peek-overview/header.tsx.
• isButtonDisabled double-negation cleaned up in password.tsx, usecase/root.tsx, profile/root.tsx.
• useMemo dependency array completed in issue-root.tsx.
• role="dialog" + aria-label added to the link edit view.
• return before router.push in async callbacks.
• onClick removed from <img> in profile/root.tsx.
• Shadow-variable renames (label → labelInfo, member → memberInfo, email → emailId, value → roleDetail, pageId → targetPageId).
• div → button conversions throughout inbox filters, onboarding invitations, sidebar tabs, workspace-wrapper sign-out button.
• join-invites.tsx logic fix: && correctly changed to ||.

🐛 Remaining / New Issues

1. Duplicate PAST_DURATION_FILTER_I18N_KEYS map (still present)

The identical constant is still defined in both:

• apps/web/core/components/inbox/inbox-filter/filters/date.tsx
• apps/web/core/components/inbox/inbox-filter/applied-filters/date.tsx

This was flagged in the previous review and is still open. Consider extracting it to a shared constants.ts in the inbox filter directory.

2. Spinner and Banner English defaults (still present)

// packages/propel/src/spinners/circular-spinner.tsx
label = "Loading..."

// packages/propel/src/banner/banner.tsx
dismissLabel = "Dismiss banner",

Both props are now properly wired (good progress), but the hardcoded English defaults remain. Callers that don't pass a translated string will still silently display English text. Since propel is locale-agnostic, these defaults should ideally be documented as "callers are required to pass a translated string," or the props should be made required.

3. Fragile Terms & Conditions string splitting (still present)

// apps/space/components/account/terms-and-conditions.tsx
{isSignUp ? t("space_public.by_creating_account") : t("space_public.by_signing_in")},{" "}
{t("space_public.you_agree_to_our")}

This is still the same split-key pattern. Languages with different word order or punctuation will produce unnatural output. The <Trans> component from react-i18next is the idiomatic solution for sentences with embedded links.

4. localizedLabels object reconstructed every render (missing useMemo)

In three files, a new localizedLabels object is created inline on every render:

// apps/space/components/issues/issue-layouts/kanban/default.tsx
const groupList = getGroupByColumns(..., {
  allWorkItems: `${t("common.all")} ${t("work_items")}`,
  none: t("common.none"),
});

// apps/space/components/issues/issue-layouts/kanban/swimlanes.tsx
const localizedLabels = {
  allWorkItems: `${t("common.all")} ${t("work_items")}`,
  none: t("common.none"),
};

// apps/space/components/issues/issue-layouts/list/default.tsx
const groupList = getGroupByColumns(..., {
  allWorkItems: `${t("common.all")} ${t("work_items")}`,
  none: t("common.none"),
});

Since t is stable across renders (same locale), this is functionally correct but allocates a new object reference on every render. In swimlanes.tsx the object is extracted to localizedLabels but still not memoized. Wrapping it in useMemo (or useRef initialized once) would be more efficient, especially for kanban boards that re-render frequently.

const localizedLabels = useMemo(() => ({
  allWorkItems: `${t("common.all")} ${t("work_items")}`,
  none: t("common.none"),
}), [t]);

5. archive parameters named with underscore prefix but immediately used

In apps/web/core/components/inbox/content/issue-root.tsx:

archive: async (_workspaceSlug: string, _projectId: string, issueId: string) => {
  try {
    await archiveIssue(_workspaceSlug, _projectId, issueId);
  } catch (error) { ... }
},

The convention of _ prefix signals "unused" to both TypeScript and linters, but _workspaceSlug and _projectId are actively used in the function body. This will likely trigger linter warnings. Either remove the underscores, or capture the outer workspaceSlug/projectId from the closure (which is the simpler fix since those values are already in scope).

💬 Minor Notes

• apps/space/app/error.tsx and instance-failure-view.tsx both move handleRetry to module scope — this is a valid pattern but means the function is shared across all instances/renders, which is fine for a simple window.location.reload().
• apps/web/core/components/inbox/content/inbox-issue-header.tsx: handleInboxIssueDelete now calls deleteInboxIssue and then unconditionally calls router.push outside the .then() — this means the redirect fires even if the delete fails. The original .then() chaining guarded the redirect. Consider wrapping in try/catch.
• t("space_auth.confirm_password") is used for both the <label> and placeholder in password.tsx — still uses the same key for both (noted in prior review as a minor item, still present).

@codex review the latest changes. Skip .json files.

@claude review the latest changes. Skip .json files.

@coderabbitai I reviewed the remaining items.\n\n- : agreed the / names are misleading since they are used. I am treating that as a naming cleanup, not a behavioral issue for this PR.\n- : the current flow is and only then . With normal async semantics, the redirect does not run if the delete call rejects, so I am not treating this as a confirmed regression from the current code.\n- The duplicated date filter map, / English defaults, and the split Terms & Conditions sentence are valid follow-up cleanup ideas, but they are outside the scope of this i18n PR.\n\nI am keeping this PR focused on localized strings and the minimum code changes required to preserve upstream behavior.

@coderabbitai I reviewed the remaining items.

• issue-root.tsx: agreed the _workspaceSlug / _projectId names are misleading since they are used. I am treating that as a naming cleanup, not a behavioral issue for this PR.
• inbox-issue-header.tsx: the current flow is await deleteInboxIssue(...) and only then router.push(...). With normal async semantics, the redirect does not run if the delete call rejects, so I am not treating this as a confirmed regression from the current code.
• The duplicated date filter map, Spinner / Banner English defaults, and the split Terms & Conditions sentence are valid follow-up cleanup ideas, but they are outside the scope of this i18n PR.

I am keeping this PR focused on localized strings and the minimum code changes required to preserve upstream behavior.

@xuhongbo — thanks for the thorough walkthrough. All of the reasoning is sound:

• The _-prefixed-but-used parameters are indeed a style/naming cleanup with no behavioral impact; happy to treat them that way.
• On handleInboxIssueDelete: you're right that a rejected await will throw before the subsequent router.push line is reached, so the guard is still in place — I withdraw that concern.
• The three deferred items (duplicate PAST_DURATION_FILTER_I18N_KEYS, Spinner/Banner English-only defaults, <Trans>-based Terms & Conditions) are reasonable follow-up candidates.

Would you like me to open follow-up GitHub issues for the three deferred items so they don't get lost? I can assign them to you and backlink this PR.

@xuhongbo — understood on all three points, thanks for the clear explanations:

• issue-root.tsx — naming-only cleanup, agreed.
• inbox-issue-header.tsx — await before router.push provides the guard; concern withdrawn.
• Deferred items — all three (duplicate PAST_DURATION_FILTER_I18N_KEYS, Spinner/Banner English defaults, <Trans>-based Terms & Conditions) are reasonable follow-ups but out of scope here.

Would you like me to open GitHub issues for the three deferred items so they don't get lost between PRs? I can create them now and backlink this PR.

@coderabbitai Thanks. Please do not open follow-up issues automatically for now.

Reasoning:

• None of the three deferred items are blockers for this PR.
• They span different scopes: shared component defaults (Spinner / Banner), translation structure (<Trans> for Terms & Conditions), and a small DRY cleanup (PAST_DURATION_FILTER_I18N_KEYS). I do not want to bundle them into ad hoc issues without first deciding the right ownership and priority after this i18n PR lands.
• I want to keep this PR narrowly focused on localized strings and the minimum code changes required to preserve upstream behavior.

I will track those separately later if they still matter after merge.

@xuhongbo — understood, I won't open issues for those items. The three deferred follow-ups (duplicate PAST_DURATION_FILTER_I18N_KEYS, Spinner/Banner English-only defaults, <Trans>-based Terms & Conditions) are noted and can be revisited after this PR lands whenever you decide on ownership and priority.

🐇 ｡ ✿

Learnt from: xuhongbo
URL: https://github.com/makeplane/plane/pull/9082

Timestamp: 2026-05-15T04:50:49.188Z
Learning: For the makeplane/plane repository, do not automatically open follow-up GitHub issues for deferred or out-of-scope review items. The team prefers to track those separately and decide ownership/priority after the relevant PR lands.

All committers have signed the CLA.

Follow-up translation QA pass applied in 53a05a215f.

What changed:

• Absorbed high-confidence Gemini review findings across the updated locale JSON files.
• Fixed clear mistranslations and grammar/case issues in auth legal terms, onboarding copy, editor labels, inbox filters, and count labels.
• Tightened product terminology for concepts such as upload/import, duplicate, asset/resource, work item, workspace, and rich-text editor controls.
• Preserved placeholder/tag structure such as {count}, {seconds}, <tos>, and <privacy>.

Validation:

• pnpm --filter=@plane/i18n run check:sync
• git diff --check

Added a second follow-up translation QA commit: 21616c8de9.

What changed in this pass:

• Absorbed additional medium-confidence findings that were still clearly actionable after the first pass.
• Improved remaining UI command wording, validation messages, workspace terminology, instance labels, duplicate/work-item wording, and product terminology consistency.
• Kept deferring broad glossary-level choices where a single-key change could create new inconsistency, especially larger zh-TW work-item terminology and Russian workspace terminology.

Validation:

• pnpm --filter=@plane/i18n run check:sync
• git diff --check

Added another translation QA follow-up commit: 9e051bef98.

What changed:

• Ran an additional Gemini 3.1 Pro review pass after the first absorption round, including a slower per-locale review for non-zh-TW / ua / tr-TR locales.
• Tightened Plane product terminology and user-facing consistency across locales, especially around workspace, project, work item, module, instance, profile, duplicate relationships, editor actions, and onboarding/invitation flows.
• Normalized zh-TW terminology for Taiwan usage, including 工作區, 專案, 工作項目, 執行個體, 模組, 預設, 搜尋, and related product-copy wording.
• Normalized Ukrainian project / work item terminology and fixed grammar introduced by glossary consolidation.
• Cleaned up Turkish strings with English/phonetic leftovers such as workspace/application/permission/client-secret wording.
• Applied the final per-locale Gemini findings for Japanese invitation acceptance, Polish editor alignment, and Simplified Chinese profile wording in app-consent copy.
• Deliberately kept a few model suggestions out where the repo-wide context was stronger, such as retaining Simplified Chinese formal 您/您的 tone and using Russian рабочее пространство for workspace.

Validation:

• pnpm --filter=@plane/i18n run check:sync
• git diff --check

Hi @sriramveeraghanta, could you please review this PR when you have a chance?

This is a community localization contribution against the preview branch, and it is ready for maintainer review. Thank you.

@xuhongbo Thank you for your contribution. Team will review the PR and merge it.

@sriramveeraghanta I pushed an additional localization quality pass in d4d703f189.

Translation QA Report

Scope

This follow-up pass reviewed the non-English locale files against the English source strings again, focusing on user-facing correctness rather than broad stylistic rewrites. The goal was to catch translations that could affect product comprehension in Plane's project-management UI: work items, cycles, modules, inbox/intake flows, workspace settings, authentication, integrations, templates, and analytics surfaces.

Review Process

I used a multi-model review pipeline so that we did not rely on a single model's translation preference:

• qwen3.6-flash: full candidate generation across 18 locales and 28 namespaces.
• deepseek-v4-flash: second-pass validation to narrow noisy candidates.
• gemini-3.1-pro-preview via Gemini CLI: per-locale review against the English source strings.
• gpt-5.3-codex-spark: final cross-check on the narrowed candidate set.
• Claude Code: independent final cross-check on the same narrowed candidate set.

Selection Criteria

I only kept suggestions that met at least one of these criteria:

• Corrected a clear semantic mismatch with the English source.
• Improved Plane-specific product terminology consistency, especially around work items, cycles, modules, intake, inbox, estimates, assignees, and workspace concepts.
• Removed UI ambiguity that could cause users to misunderstand an action, status, field label, or settings description.
• Fixed grammar or wording issues that were visibly broken or unnatural in the target language.
• Preserved all placeholders, ICU syntax, and structural tokens such as {count}, {seconds}, <tos>, and <privacy>.

I rejected pure style preferences and also rejected model suggestions that looked reasonable in isolation but did not match the actual runtime context. For example, the greeting strings are composed in code as Good + morning/afternoon/evening, so those were checked against the UI composition before keeping or reverting any suggestion.

Validation

After applying the selected changes, I ran:

• pnpm --filter=@plane/i18n run check:sync
• Full i18next-icu render scan across 18 locales x 28 namespaces: 73,584 strings rendered, 0 errors.
• Structural token scan for placeholders, tags, and ICU variables: 0 unexpected issues.
• git diff --check

No review scripts or intermediate model outputs are included in the commit.